Skip to content

br: add compatibility between log backup and PITR #20002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 9 commits into from
Apr 10, 2025
Merged

br: add compatibility between log backup and PITR #20002

ti-chi-bot merged 9 commits into from
Apr 10, 2025

Conversation

@YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Mar 6, 2025 •
edited by lilin90
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

增加了日志备份和恢复的兼容性章节。

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2025
BornChanger
BornChanger reviewed Mar 6, 2025
View reviewed changes
BornChanger
BornChanger reviewed Mar 6, 2025
View reviewed changes
@YuJuncen @BornChanger
Update br/br-pitr-manual.md
28e3c57 
Co-authored-by: BornChanger <97348524+BornChanger@users.noreply.github.com>
@lilin90 lilin90 self-assigned this Mar 7, 2025
@lilin90 lilin90 requested a review from hfxsd March 7, 2025 03:28
@lilin90 lilin90 added v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. translation/doing This PR’s assignee is translating this PR. labels Mar 7, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 7, 2025
@lilin90 lilin90 changed the title br: 新增日志备份与恢复之兼容性 br: add compatibility between log backup and PITR Mar 11, 2025
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 11, 2025
@lilin90 lilin90 mentioned this pull request Mar 11, 2025
Merged
16 tasks
lilin90
lilin90 reviewed Mar 13, 2025
View reviewed changes
@YuJuncen @lilin90
Apply suggestions from code review
b62eed0 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 13, 2025

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lilin90
lilin90 reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot-review

@qiancai
Copy link
Collaborator

qiancai commented Apr 8, 2025

/bot-review

github-actions[bot]
github-actions bot reviewed Apr 8, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Apr 8, 2025

✅ AI review completed, 5 comments generated.

lilin90
lilin90 reviewed Apr 8, 2025
View reviewed changes
lilin90
lilin90 reviewed Apr 9, 2025
View reviewed changes
@lilin90 @github-actions
Apply suggestions from code review
eba143e 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lilin90
lilin90 reviewed Apr 9, 2025
View reviewed changes
lilin90
lilin90 reviewed Apr 9, 2025
View reviewed changes
@lilin90
Copy link
Member

lilin90 commented Apr 9, 2025

/test pull-verify

hfxsd
hfxsd reviewed Apr 9, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 9, 2025
@lilin90 @hfxsd
Apply suggestions from code review
0cdfeae 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
lilin90
lilin90 approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 10, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-09 12:22:30.785915819 +0000 UTC m=+2259044.470151914: ☑️ agreed by hfxsd.
  • 2025-04-10 02:26:52.342215821 +0000 UTC m=+2309706.026451916: ☑️ agreed by lilin90.

@lilin90
Copy link
Member

lilin90 commented Apr 10, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 10, 2025
@ti-chi-bot ti-chi-bot bot merged commit 3b6cb60 into pingcap:master Apr 10, 2025
7 checks passed
@lilin90 lilin90 added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 11, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 11, 2025
Open
16 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 11, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #21175.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 11, 2025
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@lilin90 lilin90 lilin90 approved these changes

@hfxsd hfxsd hfxsd approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees

@lilin90 lilin90

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@YuJuncen @qiancai @lilin90 @ti-chi-bot @hfxsd @BornChanger